Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataMaster-Android-AdBlock-Hosts to the default blockinglist #616

Closed
DataMaster-2501 opened this issue Jan 10, 2020 · 10 comments
Closed
Assignees

Comments

@DataMaster-2501
Copy link

DataMaster-2501 commented Jan 10, 2020

(I was told by Peter to open this here)

I make my own Hosts filter list & wanted to know if I could have it added to the list of filter lists that users get to pick from?
I work hard to keep this list updated & want to share it with as many people as I can so they don't have to do all this work to enjoy ad free Internet & Apps. I also try to respond to any issues with my list as fast as I can & I try to encourage people report any kind of issue with my list.

https://github.com/DataMaster-2501/DataMaster-Android-AdBlock-Hosts

https://github.com/DataMaster-2501/DataMaster-Android-AdBlock-Hosts/blob/master/hosts?raw=true

Small Description: This list blocks Ads/Marketing Services, Analytics/Tracking Service.
I can be contacted on GitHub for any issues.

@Ch4t4r
Copy link

Ch4t4r commented Jan 13, 2020

Off-topic, but (from the repos README)

If you want to make money💰 then make people pay for your App

Almost all users expect free apps. Free apps reach far more users. Just imagine if Blokada was paid, there are other apps which can do similar things and Blokada would have never gotten this popular.

If you want to make the App free then make it free with no Ads you Greedy Pigs!!!!

Don't use it then? A developer invested his time and offers you an App for free and you blame them for adding ads. Good job.

I'm not really sure if you are sarcastic with these statements. I hope you are.

Now, on topic:

I don't really believe that you compiled a 10mb hosts file yourself - if you did: good job (again). You don't mention any sources in your repository, which did you use (if any)?

Also, why did you choose the AGPL? The GPL should be enough for a hosts file.

@androidacy-user
Copy link

Wait are we saying blokada has ads or did I miss something?

@Ch4t4r
Copy link

Ch4t4r commented Jan 13, 2020

No, I just criticised his readme.

Also, he seems to be pretty disrespectful (from AdAway/adaway.github.io#23)

" I've administered KES Endpoint Security myself and I found it to be the most thoroughly impressive software I've ever administered."
Shows what you know LOL!

@androidacy-user
Copy link

Omfg what has GitHub come to?

"Shows what you know LOL"

Anyhow enough OT

@DataMaster-2501
Copy link
Author

DataMaster-2501 commented Jan 13, 2020

So is that a no to my request??😕
Also the AdAway people were being illogical over why they will not add my list to the "HostsSources"
Users get to pick what lists they use,
so if it does not work for them then they can pick some other list.
No one is forcing the list down the users throat.
@Ch4t4r As for my README that is how I feel & I really don't care what you think about it.😒

"Free ad blocker for Android with the best open source community. "
To Blokada Devs: You mean the best open source community of trolls🙄
I did not come here for criticism I came here to ask if my list can be added.😒

@DataMaster-2501
Copy link
Author

DataMaster-2501 commented Jan 13, 2020

p.s.
"I don't really believe that you compiled a 10mb hosts file yourself - if you did: good job (again). You don't mention any sources in your repository, which did you use (if any)?"
@Ch4t4r I did compile a 10.5mb hosts file myself. I've been working on it for many many years long before I started a git for it 😜
It's one of my many hobbies.

@peterroth peterroth changed the title I would like to add my filter list to the list of filter lists that users get to pick from. Add DataMaster-Android-AdBlock-Hosts to the default blockinglist Jan 14, 2020
@peterroth
Copy link
Contributor

Thank you for the request @DataMaster-2501.
I checked the mentioned list and I can see you redirect 166630 hosts once for IPv4 (0.0.0.0) and once for IPv6 (::1). May I ask why?
4 hosts are redirected only for IPv4.
The following hosts are redirected 3-4 times:

Number of redirections | Hostname
3 | analytics.kingoapp.com
4 | d346whrrklhco7.cloudfront.net
4 | microsoftsto.112.2o7.net

If I check the microsoftsto.112.2o7.net I can see 2 lines carry not only one hostname, but 2:

0.0.0.0       microsoftsto.112.2o7.net
0.0.0.0       microsoftsto.112.2o7.net go.com
::1 microsoftsto.112.2o7.net
::1 microsoftsto.112.2o7.net go.com

@peterroth peterroth self-assigned this Jan 20, 2020
@DataMaster-2501
Copy link
Author

@peterroth Let me start off with sry about the type typo & duplicate lines.
My last update was rushed a little bit so that's why I have some duplicate lines so really sry about that.
As for the typo ::1 microsoftsto.112.2o7.net go.com I'm not sure how go.com got in there
but Thank you soo much for pointing that out, I will fix all of this soon.

"I checked the mentioned list and I can see you redirect 166630 hosts once for IPv4 (0.0.0.0) and once for IPv6 (::1). May I ask why?"
Well back when I started this list it was on my rooted phone
& there was no "blokada app" So I just added it to my /etc/hosts file on phone.
back then I only did IPv4 in the list.
Over time I saw that some domains were not being blocked when I was on 3g or LTE.
Then I saw that when I was on 3g or LTE I had both IPv4 IPv6 & that the domains getting by my block also used both IPv4 and IPv6.
So I added IPv6 and that fixed everything.
I made this list to be dropped into /etc/ on a rooted phone.
So that is why.
My phone is rooted & I don't use blokada
but my mom & many of my friends don't have rooted phones
so they use my list with blokada that I had setup for them & everything works fine for them.
I like blokada it's a well made app.

@DataMaster-2501
Copy link
Author

@peterroth I fixed everything & updated list.
https://github.com/DataMaster-2501/DataMaster-Android-AdBlock-Hosts/releases/tag/1.8

p.s. after looking over somethings in blokada, I now see where you are coming from about the IPv4 & IPv6 but blokada is not loading both. It stops at 170725 so by having both is not hurting anything other then making users download 5MB more of data then they need.
If you want I could make 2 files:
my normal /etc/hosts file & one just for blokada
Let me know.

@peterroth
Copy link
Contributor

peterroth commented Feb 27, 2020

Most of the hosts are added twice to block IPv4 and IPv6 as well, however there are 4 that added once:

www.google.comsecure.adultfriendfinder.com
ad.rtbq.spotx.tv
rtbq.spotx.tv
r.254a.com

Additionally, I'm not sure if the hostname www.google.comsecure.adultfriendfinder.com really exist, it seems to be a merged one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants