Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blokada does not change theme dynamically #893

Closed
soredake opened this issue Sep 8, 2021 · 8 comments
Closed

Blokada does not change theme dynamically #893

soredake opened this issue Sep 8, 2021 · 8 comments
Labels

Comments

@soredake
Copy link

soredake commented Sep 8, 2021

When android theme changes to dark blokada's theme is still staying light, even when "system theme" is selected in options.

@kar
Copy link
Contributor

kar commented Sep 24, 2021

What device, os?

@kar kar added the type-B Bug label Sep 24, 2021
@soredake
Copy link
Author

Redmi Note 5 Pro, crdroid (android 11)

@qwerty287
Copy link

Same here, stock android 11

@kar
Copy link
Contributor

kar commented Sep 24, 2021

Do you restart the app fully? You need to kill the app if VPN is established or Keep Alive is enabled.

@qwerty287
Copy link

OK, if I kill the app it works. But that's not a very nice behavior. Usually, android apps automatically switch to dark ui if it is changed, without an app restart or even an app kill. Actually, Android handles this exactly like this if you do not change it manually and if you have the theme declarations in both directories values and values-night.

@kar
Copy link
Contributor

kar commented Oct 22, 2021

Yep but you are talking about only some recent Android versions and only some device models. Theme handling has been historically very inconsistent in Android. We have done it with a separate library in order to support a broader range of devices. We may revisit it and go back to Android native way once the more recent Android versions are more common.

@soredake
Copy link
Author

once the more recent Android versions are more common.

https://www.xda-developers.com/android-distribution-numbers-2021/

@soredake
Copy link
Author

Blokada 5/6 now dynamically changes theme, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants