Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minsdk should be 21 #16

Closed
chitgoks opened this issue May 15, 2020 · 6 comments
Closed

minsdk should be 21 #16

chitgoks opened this issue May 15, 2020 · 6 comments

Comments

@chitgoks
Copy link

hi correct me if im wrong

shouldn't min sdk be 21 instead of the current 15? there would be no point to have those vector images since it will still generate pngs.

@blongho
Copy link
Owner

blongho commented May 15, 2020

I will make a patch with the minsdk 21. I think you are correct about the vector images.

@chitgoks
Copy link
Author

thanks blongho!

@blongho
Copy link
Owner

blongho commented May 15, 2020

Hi @chitgoks
What is your experience with this

    implementation 'com.github.blongho:worldCountryData:ffa9b81b7c'

The only change there is upgrading the min-sdk to 21.

@chitgoks
Copy link
Author

Hmm same result. weird. i have no idea why. i already set min sdk to 21 in my project and explicitly set vectorDrawables.useSupportLibrary to false

@blongho
Copy link
Owner

blongho commented May 24, 2020

Evidently, changing the minSdk to 21 does not resolve your problem. I will close this issue

@blongho blongho closed this as completed May 24, 2020
@chitgoks
Copy link
Author

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants