Make classes "Country" and "Currency" Parcelable and fix spelling error in *Continent* Enum #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fatonhoti thanks for your contribution. The feature has been successfully merged. If there is additional feature that you want to include in the library, please free feel to make a pull request. |
|
@blongho Great, thank you! Are you planning on making a new release anytime soon so we can make use of the new feature? As of right now v1.5.1 does not have this feature. |
Repository owner
deleted a comment from
benorine
Apr 4, 2022
|
Yes @fatonhoti , it is now v1.5.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to send for example a
List<Country>from one activity to another via Intents, my application was crashing due to the fact that the classCountrywas not Parcelable. This pull request is my attempt to make the classesCountryandCurrency(Currency needs to be Parcelable too otherwise Country can't write Currency objects to it's Parcel) Parcelable in order to allow for the described functionality to work without crashing.Furthermore I noticed a spelling error in the enum regarding the continents, so I fixed that.