Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some countries doesn`t have flags #42

Closed
Radcat501 opened this issue May 13, 2022 · 3 comments
Closed

Some countries doesn`t have flags #42

Radcat501 opened this issue May 13, 2022 · 3 comments

Comments

@Radcat501
Copy link

Radcat501 commented May 13, 2022 •
edited

Hello!

I am using function:
World.getFlagOf(item.CodeAlpha2)

Works fine, but some countries and regions does not have flags:

  • Saint Maarten
  • Turkmenistan
  • Gibraltar
  • French Polynesia
  • New Caledonia
  • Wallis and Futuna
  • Indonesia
  • Guernsey
  • Ghana
  • Hong Kong
  • Macao

Thank you.
@blongho
Copy link
Owner

blongho commented Jun 6, 2022

@Radcat501 Thanks for this. I am currently looking at the issue. Will be fixed in the days ahead

@blongho
Copy link
Owner

blongho commented Jun 6, 2022

@Radcat501 Thanks for this feedback. There was an implementation issue that excluded countries without currencies or whose currencies lacked symbol and/or name.

It is now left to the developer to make the check!

@blongho blongho closed this as completed Jun 6, 2022
@Radcat501
Copy link
Author

Thank you for fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Radcat501 @blongho