Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile friendly display #62

Open
bloodybowlers opened this issue Aug 16, 2019 · 3 comments
Open

Mobile friendly display #62

bloodybowlers opened this issue Aug 16, 2019 · 3 comments

Comments

@bloodybowlers
Copy link
Owner

There is currently no mobile/tablet version of the display.

Massive switch to bootstrap, or a simple hack to detect mobile and try to adapt the display ?

The problem with the current UkeGeeks display, imho, is that it is made to be easily printable.
This enable printing rather easily, but it restrict the display a lot...

@Louis-coding-UGNG
Copy link
Contributor

I'd vote for the detection method and build a layout for mobile only - this will duplicate some pages but is most probably less effort than a "all-in-one" solution.

On the other hand a mobile friendly version should IMHO also include minified css and js files to save bandwidth.

@bloodybowlers
Copy link
Owner Author

You are right, an all-in-one solution would be a pain, especially given the current state of the code...

We could try to make mobile version of login/song-list/song-edit page.
But I think we need to make the song-edit page read only. I mean, who is using a mobile/tablet to add songs anyway ? It's a pain. You just need to be able to read it and play !

@Louis-coding-UGNG
Copy link
Contributor

In another project I used https://github.com/serbanghita/Mobile-Detect for switching....

I am not so sure about the read-only. It should be default for mobiles, but not the only option. It does happen that you discover errors or have new ideas - and then you're quite happy to have an editing option in the back (even when it is a bit painful). When editing on mobile device the editor should be fullscreen (in a new tab?), not just the small overlay we have on desktop; the advanced editor seems too much....
Brainstorming:

  • send mobile devices to the public "read-only" page with a mobile friendly layout
  • leave the login option available
  • mobile editing only in fullscreen mode (can we trigger a page refresh in another tab for previewing? Or can we skip such functionality for the time being?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants