ADF#B support

[Louis-coding-UGNG]

That's the only common ukulele tuning missing right now in the tool - and yet it is quite popular in some parts of the world.

And some ukes simply sound better tuned a full step up.

[bloodybowlers]

In src/js/scriptasaurus/ukeGeeks.definitions.js I see :

        /**
	 * Enum (simple JSON name/value pairs) defining instrument tunings (offsets from standard Ukulele)
	 * @property instrument
	 * @type JSON
	 */
 _public.instrument = {
		standardUke: 0, // GCEA
		baritoneUke: 5 // DGBA -- Baritone's "A" fingering is the standard's "D"
	};

@acelan made this commit 9dcdb04 in an ukeGeeks PR :

_public.instrument = {
		sopranoUke: 0, // GCEA -- standard tuning G4 (or G3)-C4-E4-A4
		baritoneUke: 5 // DGBE -- 5 steps lower than standard Soprano tuning: D3-G3-B3-E4
		alternateUke: 2 // ADF#B -- 2 steps higher than standard tuning A4 (or A3)-D4-F#4-B4
	};

Should be enough ?

[Louis-coding-UGNG]

Unfortunately not.

First of all there's a comma missing after baritoneUke: 5
Secondly, it's not 2 but -2 steps lower (=2 steps higher)

And only adding this single line of code doesn't make ADF#B appear in the transpose menu...
The new tuning must be added to the doTuning method in editor, the song_editable.php view and probably somewhere else as well - and at least the method useInstrument must be made capable of handling the negative value somehow to rename and redraw the chords correctly (same chord is fretted 2 steps lower, e.g. a C on ADF#B is fretted like Bb on GCEA)

And that's probably only the tip of the iceberg....

[bloodybowlers]

I had hope because bariton doesn't have a specific definition file (like the standard one : ukeGeeks.definitions.standardUkuleleGcea.js)...

I though it was just automatically transposing for each tuning (somehow it is doing this for baritone).

And that's probably only the tip of the iceberg....

I'm afraid you are right...

[Louis-coding-UGNG]

I don't know if the negative offset really is a problem (mostly due to my lack of JS knowledge). If that is the bigger chunk another possible solution (albeit a tedious one) might be to rewrite all internal chord definitions to ADF#B (as the highest tuning in scope) and use the current DGBE logic for GCEA as well by defining GCEA tuning with 2 steps offset - but even then the new tuning needs to be added in a couple of files.