Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user defined chords inside a song are not transposed #67

Open
Louis-coding-UGNG opened this issue Aug 21, 2019 · 2 comments
Open

user defined chords inside a song are not transposed #67

Louis-coding-UGNG opened this issue Aug 21, 2019 · 2 comments

Comments

@Louis-coding-UGNG
Copy link
Contributor

Song definitions inside a song are not affected by transposition nor tuning changes.

Steps to recreate this error:

  1. Add a non-standard chord to a song source, e.g.
    {define: Am7sus5 frets 2 0 0 0 fingers 2 0 0 0}
  2. Use this chord in the song
  3. Transpose up or down:
    you get an error message "Some of your chords can't be transposed: Am7sus5"
  4. Stick to original key and change the tuning:
    the user defined chord is silently ignored, i.e. no error msg pops up and the chord diagram is not changed.

Expected behaviour:

  • Ideally:
    user defined chord definitions are changed like predefined chords on transposition and tuning changes. Challenge here is that recalculating the fret positions with the defined offset is hardly sufficient, e.g. tranposing two steps down from Am (frets 2 0 0 0) cannot result in Gm (frets 0 -2 -2 -2). The other way round might work: two steps up from Am (frets 2 0 0 0) could end up in a valid Bm (frets 4 2 2 2), but it could as well end up in impossible chord shapes.
  • Realistic for the time being:
    the error message pops up on every tuning change as well as for transposition.
  • future idea
    somehow include at least the tuning in the chord definition - and show only the diagrams relevant for the currently active tuning

(NB: I have not tested that scenario with the original UkeGeeks, might well be a similar problem there...)

@bloodybowlers
Copy link
Owner

(NB: I have not tested that scenario with the original UkeGeeks, might well be a similar problem there...)

It seems it is, unfortunately...

@bloodybowlers bloodybowlers changed the title user defined chords are not transposed user defined chords inside a song are not transposed Aug 21, 2019
@Louis-coding-UGNG
Copy link
Contributor Author

Well, then lets go for the "realistic" approach (notify on transposition and tuning change that chords inside the song are not modified) and label it as a feature request for a future milestone where some more help is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants