You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Song definitions inside a song are not affected by transposition nor tuning changes.
Steps to recreate this error:
Add a non-standard chord to a song source, e.g. {define: Am7sus5 frets 2 0 0 0 fingers 2 0 0 0}
Use this chord in the song
Transpose up or down:
you get an error message "Some of your chords can't be transposed: Am7sus5"
Stick to original key and change the tuning:
the user defined chord is silently ignored, i.e. no error msg pops up and the chord diagram is not changed.
Expected behaviour:
Ideally:
user defined chord definitions are changed like predefined chords on transposition and tuning changes. Challenge here is that recalculating the fret positions with the defined offset is hardly sufficient, e.g. tranposing two steps down from Am (frets 2 0 0 0) cannot result in Gm (frets 0 -2 -2 -2). The other way round might work: two steps up from Am (frets 2 0 0 0) could end up in a valid Bm (frets 4 2 2 2), but it could as well end up in impossible chord shapes.
Realistic for the time being:
the error message pops up on every tuning change as well as for transposition.
future idea
somehow include at least the tuning in the chord definition - and show only the diagrams relevant for the currently active tuning
(NB: I have not tested that scenario with the original UkeGeeks, might well be a similar problem there...)
The text was updated successfully, but these errors were encountered:
Well, then lets go for the "realistic" approach (notify on transposition and tuning change that chords inside the song are not modified) and label it as a feature request for a future milestone where some more help is needed.
Song definitions inside a song are not affected by transposition nor tuning changes.
Steps to recreate this error:
{define: Am7sus5 frets 2 0 0 0 fingers 2 0 0 0}
you get an error message "Some of your chords can't be transposed: Am7sus5"
the user defined chord is silently ignored, i.e. no error msg pops up and the chord diagram is not changed.
Expected behaviour:
user defined chord definitions are changed like predefined chords on transposition and tuning changes. Challenge here is that recalculating the fret positions with the defined offset is hardly sufficient, e.g. tranposing two steps down from Am (frets 2 0 0 0) cannot result in Gm (frets 0 -2 -2 -2). The other way round might work: two steps up from Am (frets 2 0 0 0) could end up in a valid Bm (frets 4 2 2 2), but it could as well end up in impossible chord shapes.
the error message pops up on every tuning change as well as for transposition.
somehow include at least the tuning in the chord definition - and show only the diagrams relevant for the currently active tuning
(NB: I have not tested that scenario with the original UkeGeeks, might well be a similar problem there...)
The text was updated successfully, but these errors were encountered: