We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently business logic for User module is spread across controller and service, which by convention should not be the case. Example:
async create( @Body() dto: UserCreateDto, @Query() queryParams: UserCreateQueryParams ): Promise<UserBasicDto> { const user = await this.userService.createUser(dto) if (!queryParams.noWelcomeEmail) { await this.emailService.welcome(user, dto.appUrl) } return mapTo(UserBasicDto, user) }
sending welcome emails should be encapsulated within User service.
The text was updated successfully, but these errors were encountered:
pbn4
No branches or pull requests
Currently business logic for User module is spread across controller and service, which by convention should not be the case. Example:
sending welcome emails should be encapsulated within User service.
The text was updated successfully, but these errors were encountered: