Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create style utility classes and page header variant needed for Rent/Buy affordable housing header #1405

Closed
akegan opened this issue Jun 23, 2021 · 3 comments
Labels
sf request Changes requested by the DAHLIA team

Comments

@akegan
Copy link
Contributor

akegan commented Jun 23, 2021

DAHLIA Jira issue

Components

Goal

As as developer I want access to common building blocks for simple text styles

Underlined Heading

Propose implementing as a custom css class .underlined-heading with a helper to add caps .is-caps ( see global/text.scss , currently.text-caps-underline)

Numbered List

Propose implementing as a custom css class rather than a component .numbered-list (see .custom-counter as an example)

Aside Block

We have a current css utility called .aside-block that could be leveraged for this. (see global/blocks.scss as an example)

Utility Mockups
https://www.figma.com/file/tUtgsJO8XnF9Ij2dwu22EF/bloom-general?node-id=338%3A515

Page Header

Propose adding background color option to page header component
https://www.figma.com/file/tUtgsJO8XnF9Ij2dwu22EF/bloom-general?node-id=335%3A470

Context

At the top of our rental and sale listing pages, we provide a bit of additional context to users, including eligibility requirements for the Sale directory. I don't think that we necessarily need to put the whole headers into the ui-components library, but we should probably add some pieces of the components

DAHLIA designs

Sale version

Desktop:
image
Mobile:
image

Rental header

The rental version is much simpler, and might not require any new UI components (maybe just they grey background?
Desktop:
image
Mobile:
image

Suggested components

From a look at our pattern lib and the bloom ui-components, these are the components I think we'd need. I've linked to the DAHLIA pattern lib version too in case that helps.

  1. This header variation (unless it exists in bloom components elsewhere). We might also want to consider not using all-caps when reproducing it because it's harder for folks to read.
    image

  2. This white box with info which it looks like we call a directory header sidebar
    image

  3. This numbered list
    image

@akegan akegan added the sf request Changes requested by the DAHLIA team label Jun 23, 2021
@slowbot
Copy link
Collaborator

slowbot commented Jun 28, 2021

@akegan I think we have styles for much of this.

Is your desire to have distinct components or custom utility classes that could be applied when building the layout?
Ex. h-caps-lined could be broken into two css utilities that could be applied or you could have a single component with a variation

@akegan
Copy link
Contributor Author

akegan commented Jun 28, 2021

Custom utility classes could be fine! For the header it'd be nice to have a component (or a variation on a component) since we'll use it in a few different places.

Do you have the numbered list somewhere? Could it be a variation on a component that already exists?

@slowbot slowbot changed the title Create ui-components needed for Rent/Buy affordable housing header Create style utility classes and page header variant needed for Rent/Buy affordable housing header Jul 17, 2021
@akegan
Copy link
Contributor Author

akegan commented Dec 29, 2021

closing because much of this was accomplished in #1696

@akegan akegan closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Development

No branches or pull requests

2 participants