Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueueOptions docs do not document the behavior of 0 max_unconfirmed_* #36

Closed
pniedzielski opened this issue May 20, 2024 · 0 comments · Fixed by #37
Closed

QueueOptions docs do not document the behavior of 0 max_unconfirmed_* #36

pniedzielski opened this issue May 20, 2024 · 0 comments · Fixed by #37
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@pniedzielski
Copy link
Collaborator

Bug Report

Current Behavior
The example consumers we provide construct QueueOptions using the expression QueueOptions(0, 0, 0). Users building their first consumer are likely to copy this example code. However, the docs do not specify what the behavior of 0 for the first two arguments, max_unconfirmed_messages and max_unconfirmed_bytes, is.

Expected behavior/code
The documentation should mirror what the C++ SDK documentation for its component bmqt_queueoptions says: 0 for these queue options means there is no maximum number of unconfirmed messages for this consumer/maximum size of unconfirmed messages for this consumer.

@pniedzielski pniedzielski added bug Something isn't working documentation Improvements or additions to documentation labels May 20, 2024
@pniedzielski pniedzielski self-assigned this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant