Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] travis ci build #342

Merged
merged 1 commit into from
May 5, 2016
Merged

[ci] travis ci build #342

merged 1 commit into from
May 5, 2016

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented May 4, 2016

No description provided.

@bobzhang
Copy link
Member Author

bobzhang commented May 4, 2016

the failure is due to the runtime is implemented (assume we have patched the stdlib), to make it universal, we should lift such assumption

@bobzhang
Copy link
Member Author

bobzhang commented May 5, 2016

I learned it a hard way.. the [cmi_format] is different, Marshal will segfault, which means if we want to go cross-compile, we should not rely on the stdlib by the crossed compiler so we have to bump cmi_magic_number first.

Even if we manage to avoid reading any cmi files from stdlib(of the old compiler), the merlin built using ocaml 4.02.3 will not be compatible with bucklescript, seems the cost is pretty high.

Let's put the idea of cross compilng on hold

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.446% when pulling 0f76e88 on travis_ci_continue into 90c4290 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.446% when pulling f25ebc4 on travis_ci_continue into 90c4290 on master.

@bobzhang bobzhang merged commit ab3acf0 into master May 5, 2016
@bobzhang bobzhang deleted the travis_ci_continue branch May 5, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants