Add tests for problems exposed by cosmic-ray

[fophillips]

job ID 1f37d3c49055482e8dbcea3a1d3f8830:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -13,7 +13,7 @@
         app.add_url_rule(rule=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=['POST'])
         self._hooks = collections.defaultdict(list)
         self._logger = logging.getLogger('webhook')
-        if ((secret is not None) and (not isinstance(secret, six.binary_type))):
+        if ((secret != None) and (not isinstance(secret, six.binary_type))):
             secret = secret.encode('utf-8')
         self._secret = secret


job ID 2e66309c18ed4f9c8953fc622f5f5211:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1 0
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -32,7 +32,7 @@
     def _postreceive(self):
         'Callback from Flask'
         digest = self._get_digest()
-        if (digest is not None):
+        if (digest != None):
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)

job ID 634be3d1ff434425bf254ead62935081:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1 9
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) != 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID 5ae6d0a91c2d4684b02aaa340d9d3eab:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 1
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) > 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID 4a2be988d3894f3d8d9fdc46b55fa306:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 4
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) is not 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID 3933a0d64fe546699d25aed4d58afece:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 8
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) < 2) or (sig_parts[0] < 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID f8a284e6c67f4f669de506b73523cb11:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 0
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) < 2) or (sig_parts[0] > 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID d7f60eb0989f4aacabd62e9086d87975:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 2
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) < 2) or (sig_parts[0] is 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID 12a01fb33247430394d523dce2bdf91a:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 4
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if ((len(sig_parts) < 2) or (sig_parts[0] not in 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

job ID a300f614a83a4c109e266885c72fc6c0:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 5
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -40,7 +40,7 @@
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()
-        if (data is None):
+        if (data == None):
             abort(400, 'Request body must contain json')
         self._logger.info('%s (%s)', _format_event(event_type, data), _get_header('X-Github-Delivery'))
         for hook in self._hooks.get(event_type, []):

job ID 498e409e8cff49ceb7a6af2505d8ea98:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ u n a r y _ o p e r a t o r   1
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -34,7 +34,7 @@
         digest = self._get_digest()
         if (digest is not None):
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
-            if (not isinstance(digest, six.text_type)):
+            if isinstance(digest, six.text_type):
                 digest = six.text_type(digest)
             if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')

job ID af7031344c8f4fb4ae68441982768390:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   n u m b e r _ r e p l a c e r   0
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -33,7 +33,7 @@
         'Callback from Flask'
         digest = self._get_digest()
         if (digest is not None):
-            sig_parts = _get_header('X-Hub-Signature').split('=', 1)
+            sig_parts = _get_header('X-Hub-Signature').split('=', 2)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
             if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):

job ID e6f95eb27afc43149a31b00e09224996:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   n u m b e r _ r e p l a c e r   6
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -45,7 +45,7 @@
         self._logger.info('%s (%s)', _format_event(event_type, data), _get_header('X-Github-Delivery'))
         for hook in self._hooks.get(event_type, []):
             hook(data)
-        return ('', 204)
+        return ('', 205)

 def _get_header(key):
     'Return message header'

job ID a3c71ec1bc31429c97003395b4ab6389:survived:github_webhook.webhook
command: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   r e p l a c e _ o r _ w i t h _ a n d   1
--- mutation diff ---
--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py
@@ -36,7 +36,7 @@
             sig_parts = _get_header('X-Hub-Signature').split('=', 1)
             if (not isinstance(digest, six.text_type)):
                 digest = six.text_type(digest)
-            if ((len(sig_parts) < 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):
+            if (((len(sig_parts) < 2) and (sig_parts[0] != 'sha1')) or (not hmac.compare_digest(sig_parts[1], digest))):
                 abort(400, 'Invalid signature')
         event_type = _get_header('X-Github-Event')
         data = request.get_json()

total jobs: 79
complete: 79 (100.00%)
survival rate: 17.72%