Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Protobuf Extensions Support #36

Closed
yeenow123 opened this issue Jan 17, 2019 · 4 comments · Fixed by #55
Closed

Protobuf Extensions Support #36

yeenow123 opened this issue Jan 17, 2019 · 4 comments · Fixed by #55
Milestone

Comments

@yeenow123
Copy link

This is more of a question rather than issue. Is it planned or even possible to support protobuf extensions?

@kparlar
Copy link

kparlar commented Jan 20, 2019

I have got exception for the same problem i believe
image

@fenos
Copy link
Contributor

fenos commented Feb 4, 2019

Hi,

This is something that I need to verify, given that the parsing logic is all done by the protobuf.js I'm not sure if they allow for different extension. Will dig into this and come back here

@fenos fenos added this to the 1.3.0 milestone Mar 6, 2019
@bjaglin
Copy link

bjaglin commented Mar 17, 2019

We also bitten by this. It does look like protobuf.js supports it: https://github.com/dcodeIO/protobuf.js/blob/e8449c4bf1269a2cc423708db6f0b47a383d33f0/tests/comp_options-textformat.js

I am getting an error when importing something even more simple that their test case in BloomRPC:

syntax = "proto3";

import "google/protobuf/descriptor.proto";

extend google.protobuf.FieldOptions {
  string description = 50000;
}

I'll see if I can run BloomRPC locally from the sources to investigate.

@bjaglin
Copy link

bjaglin commented Mar 17, 2019

It looks like something explicit is needed https://github.com/dcodeIO/protobuf.js/blob/d6e3b9e/src/common.js#L36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants