Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-blosc-1.5.0 compilation broken on non-SSE2 platforms #75

Closed
skororu opened this issue Dec 16, 2014 · 1 comment
Closed

c-blosc-1.5.0 compilation broken on non-SSE2 platforms #75

skororu opened this issue Dec 16, 2014 · 1 comment

Comments

@skororu
Copy link

skororu commented Dec 16, 2014

See discussion here : https://trac.macports.org/ticket/45964#comment:6

On the test platform, if I compare c-blosc-1.4.1 (which compiles) and c-blosc-1.5.0 (which doesn't), the definitions of shuffle and unshuffle were updated in 1.5.0 in shuffle.h to make the argument _src const, but the change wasn't reflected in lines 493 and 498 (the conditionally executed non-SSE2 section) of shuffle.c.

This fixes the issue:

#else   /* no __SSE2__ available */

void shuffle(size_t bytesoftype, size_t blocksize,
             const uint8_t* _src, uint8_t* _dest) {
  _shuffle(bytesoftype, blocksize, _src, _dest);
}

void unshuffle(size_t bytesoftype, size_t blocksize,
               const uint8_t* _src, uint8_t* _dest) {
  _unshuffle(bytesoftype, blocksize, _src, _dest);
}

#endif  /* __SSE2__ */
@skororu skororu changed the title blosc-1.5.0 compilation broken on non-SSE2 platforms c-blosc-1.5.0 compilation broken on non-SSE2 platforms Dec 16, 2014
@FrancescAlted
Copy link
Member

Fixed in rev ebca8a2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants