Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consensus data testing structs #178

Closed
alonmuroch opened this issue Apr 12, 2023 · 2 comments
Closed

Fix consensus data testing structs #178

alonmuroch opened this issue Apr 12, 2023 · 2 comments
Labels
ssv ssv related issues
Milestone
V0.5 (post mainnet)

Comments

@alonmuroch
Copy link
Contributor

alonmuroch commented Apr 12, 2023 •
edited
Loading

TestAttesterConsensusData, TestAggregatorConsensusData, TestProposerConsensusData, TestProposerBlindedBlockConsensusData, TestSyncCommitteeConsensusData and TestSyncCommitteeContributionConsensusData

In some cases the duty's ValidatorSyncCommitteeIndices needs to be instantiated as empty array and not nil

have (for some) missing data version and for some justifications are not initialized with an array which creates issues with comparing post test state comparison
@alonmuroch alonmuroch added the ssv ssv related issues label Apr 12, 2023
@alonmuroch alonmuroch added this to the V0.5 (post mainnet) milestone Apr 12, 2023
@alonmuroch alonmuroch mentioned this issue Apr 18, 2023
Closed
@alonmuroch
Copy link
Contributor Author

will be done in #187

@alonmuroch
Copy link
Contributor Author

fixed version setting in test fixtures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ssv ssv related issues
Projects
None yet
Milestone
V0.5 (post mainnet)
Development

No branches or pull requests
1 participant
@alonmuroch