Fix remaining stale operator ID cases #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 25ebc4f.
y0sher
previously approved these changes
Dec 16, 2023
moshe-blox
reviewed
Feb 12, 2024
moshe-blox
previously requested changes
Feb 12, 2024
…operator-id # Conflicts: # network/p2p/p2p.go # operator/validator/controller.go # operator/validator/mocks/controller.go
MatusKysel
previously approved these changes
Feb 13, 2024
olegshmuelov
requested changes
Mar 18, 2024
There was a problem hiding this comment.
following your changes, we can adjust
func (eh *EventHandler) validatorAddedEventToShare(
event *contract.ContractValidatorAdded,
shareEncryptionKeyProvider ShareEncryptionKeyProvider,
operatorData *registrystorage.OperatorData,
sharePublicKeys [][]byte,
encryptedKeys [][]byte,
) (*ssvtypes.SSVShare, *bls.SecretKey, error)in eventhandler pkg
to receive getOperatorId instead of operatorData
|
@nkryuchkov , lets fix @olegshmuelov 's comments and merge |
I think we should. Done.
Actually I think we don't even need to pass EventHandler's fields to its methods because they also have access to these fields. Simplified. |
done |
olegshmuelov
previously approved these changes
Mar 19, 2024
MatusKysel
previously approved these changes
Mar 19, 2024
nkryuchkov
dismissed stale reviews from MatusKysel and olegshmuelov
via
c42d49d
olegshmuelov
approved these changes
Mar 19, 2024
y0sher
approved these changes
Mar 19, 2024
MatusKysel
approved these changes
Mar 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix passing stale operator ID to