Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization: use miscrosoft/openssl for RSA sign/verify #1358

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

y0sher
Copy link
Contributor

@y0sher y0sher commented Mar 31, 2024

Description

This uses is based on #1274 and uses parts from #1348.

Changes

  • When running linux use https://github.com/microsoft/go-crypto-openssl/ which is orders of magnitude faster than golang std lib.
  • docker to run from ubuntu golang to have openssl by default
  • disable jemalloc because it clashes with openssl and causes panic (check the build and panic if jemalloc is present)

@y0sher y0sher changed the base branch from main to stage March 31, 2024 15:10
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 48.6%. Comparing base (1c58d5a) to head (baaedd8).

Files Patch % Lines
operator/keys/rsa_linux.go 82.2% 7 Missing and 4 partials ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

moshe-blox
moshe-blox previously approved these changes Mar 31, 2024
@y0sher y0sher merged commit ef80171 into stage Mar 31, 2024
7 checks passed
@moshe-blox moshe-blox deleted the optimization/rsa-openssl branch March 31, 2024 16:32
@y0sher y0sher mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants