Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Stop to save config.yaml #1224

Open
iizukak opened this issue Oct 15, 2020 · 2 comments
Open

Stop to save config.yaml #1224

iizukak opened this issue Oct 15, 2020 · 2 comments
Assignees

Comments

@iizukak
Copy link
Member

iizukak commented Oct 15, 2020

Currently, we are saving config.yaml the contents is same as Python config.
IMO, nobody are using config.yaml.

https://github.com/blue-oil/blueoil/blob/master/blueoil/utils/config.py#L214-L236

@oatawa1
Copy link
Contributor

oatawa1 commented Oct 15, 2020

I think we may still need config.yaml.

To generate config.py, it duplicated the input python config file, while config.yaml is generated from the config dictionary.

It's possible that when we overwrite some variables, the config.py will not get update, but config.yaml will give us the correct configuration variables.

@joelN123
Copy link
Contributor

That's a good point, thank you for bringing it up.
It looks like there are two places where config.yaml file is saved

config_util.save_yaml(environment.EXPERIMENT_DIR, config)

and
yaml_names = config_util.save_yaml(main_output_dir, config)

In train.py, it happens immediately after loading the config file. So I think there is no problem to not save the config.yaml there.
In export.py, it loads the config file, then overrides some things like BATCH_SIZE and PRE_PROCESSOR, before it then saves as config.yaml. But, after that, is the config.yaml used for anything? I understand that meta.yaml could be used for application such as demo. But I'm not sure about config.yaml.
The problem with not removing the config.yaml is that currently it can cause error when loading #1110

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants