Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packages]: ship signon-ui (needed for kaccounts) #153

Closed
mck182 opened this issue Jul 14, 2015 · 15 comments
Closed

[packages]: ship signon-ui (needed for kaccounts) #153

mck182 opened this issue Jul 14, 2015 · 15 comments

Comments

@mck182
Copy link

mck182 commented Jul 14, 2015

The signon-ui package distributed by ubuntu has a bug in it; it assumes unity running "if (platform != xcb)" so the phone with "platform == wayland" hits it and signon-ui thinks it's running in unity and so requires ubuntu-browser or somesuch to be present.

I've sent the patch to Alberto (maintainer) and it's awaiting merging. In the meantime, we'll likely require a package off a bazaar branch to not have to deal with tons of unity weirdness. I'll do a clean image test once this wild "unexpected EOF" error be gone when trying to flash.

We will need to package our own signon-ui with my patches [1] after all. The unity stuff inside signon-ui crashes when finishing the auth session and that makes it unable to add the account at all. [2] is in case you just need a diff.

[1] - https://code.launchpad.net/~mardy/signon-ui/lp1473422
[2] - http://bazaar.launchpad.net/~mardy/signon-ui/lp1473422/revision/139

@hsitter
Copy link
Member

hsitter commented Jul 15, 2015

FTR when patched we probably need to apt mark hold the patched version as to prevent other ubuntu-image induced packages from overwriting our patched version until ubuntu adopts the presented patch.

@hsitter
Copy link
Member

hsitter commented Jul 16, 2015

https://launchpad.net/~plasma-phone/+archive/ubuntu/ppa/+sourcepub/5216393/+listing-archive-extra

@jriddell please make sure to mark hold it as mentioned in the previous comment

@jriddell
Copy link

signon-ui_0.17+15.04.20150410-0ubuntu1+phone1_armhf.changes uploaded to mobileci
mobster script now has:
apt-get install -y signon-ui-service=0.17+15.04.20150410-0ubuntu1+phone1 signon-ui-x11=0.17+15.04.20150410-0ubuntu1+phone1

@mck182
Copy link
Author

mck182 commented Jul 21, 2015

I just noticed that signon-ui failed to build on arm, so it is not on the phone --> https://launchpad.net/~plasma-phone/+archive/ubuntu/ppa/+build/7658885

Not entirely sure why, the buildlog says

libEGL warning: DRI2: failed to create any config
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
Segmentation fault (core dumped)

@mck182 mck182 reopened this Jul 21, 2015
@star-buck star-buck changed the title [kaccounts] Package patched signon-ui [package]: signon-ui needed for kaccounts Jul 22, 2015
@star-buck
Copy link

@jriddell :
Has this been solved?

@mck182
Copy link
Author

mck182 commented Jul 31, 2015

The latest signon-ui armhf build is the one linked above, the failed one, so it's not solved.

Alternatively, the patch is stuck upstream waiting for QA at https://requests.ci-train.ubuntu.com/static/dashboard.html#?q=ubuntu%2Flanding-031

I don't know who to ping to get it moving though.

@star-buck star-buck changed the title [package]: signon-ui needed for kaccounts [package]: signon-ui for kaccounts Jul 31, 2015
@star-buck star-buck changed the title [package]: signon-ui for kaccounts [packages]: ship signon-ui (needed for kaccounts) Jul 31, 2015
@star-buck
Copy link

is this still pending?

@mck182
Copy link
Author

mck182 commented Sep 23, 2015

Yes, signon-ui is still failed at https://launchpad.net/~plasma-phone/+archive/ubuntu/ppa/+sourcepub/5216393/+listing-archive-extra

I'm not aware if it's being build elsewhere.

Also, signon-ui for wily already has that patch merged in, but not sure if that helps us anyhow as we're not switching to wily anytime soon.

@jriddell
Copy link

silly qemu breaking in launchpad. building now in on-demand

@jriddell
Copy link

added to seed, plasma-phone-meta updating now

@mck182
Copy link
Author

mck182 commented Sep 25, 2015

Are you sure the package has the patch actually applied? signon-ui works as if the patch wasn't built with it. Also building signon-ui from master (which is the package plus just with the patch in question) makes it work correctly as expected. So I have a reason to believe the patch is not there.

Also, can debug package be added please?

@mck182
Copy link
Author

mck182 commented Sep 28, 2015

The signon-ui 0.17+15.04.20150410-0ubuntu1+phone2 still does not have the required patch; it still doesn't work.

Also now this version is not installable without specifying the full version. apt-cache follows:

phablet@ubuntu-phablet:~$ apt-cache policy signon-ui
signon-ui:
  Installed: 0.17+15.04.20150410-0ubuntu1
  Candidate: 0.17+15.04.20150410-0ubuntu1
  Version table:
     0.17+15.04.20150410-0ubuntu1+phone2 0
        500 http://mobile.kci.pangea.pub/ vivid/main armhf Packages
        100 /var/lib/dpkg/status
     0.17+15.04.20150410-0ubuntu1+phone1 0
        500 http://ppa.launchpad.net/plasma-phone/ppa/ubuntu/ vivid/main armhf Packages
 *** 0.17+15.04.20150410-0ubuntu1 0
        500 http://ports.ubuntu.com/ubuntu-ports/ vivid/main armhf Packages
       1001 http://ppa.launchpad.net/ci-train-ppa-service/stable-phone-overlay/ubuntu/ vivid/main armhf Packages

@jriddell
Copy link

pinning rules broken :( fixing now..

Is this the patch you need? it is in the package 0.17+15.04.20150410-0ubuntu1+phone2
http://embra.edinburghlinux.co.uk/~jr/tmp/lp1473422.patch

@star-buck
Copy link

@jriddell : is this solved?

@mck182
Copy link
Author

mck182 commented Jan 14, 2016

This appears to be solved in latest image/package update.

@mck182 mck182 closed this as completed Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants