Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore block gas limit validation #236

Closed
Wodann opened this issue Oct 19, 2022 · 2 comments · Fixed by #238
Closed

Ability to ignore block gas limit validation #236

Wodann opened this issue Oct 19, 2022 · 2 comments · Fixed by #238

Comments

@Wodann
Copy link
Contributor

Wodann commented Oct 19, 2022

At hardhat we've so far been using ethereumjs, but we're rewriting parts to Rust and are using revm to do so.

One of the features that ethereumjs supports but is absent in revm is the ability to skip the validation for Return::CallerGasLimitMoreThenBlock: https://github.com/bluealloy/revm/blob/main/crates/revm/src/evm_impl.rs#L69.

In ethereumjs this is handled by providing config options for running a transaction: https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/vm/src/types.ts#L306

Is this something that you'd be willing to accept a PR for? If so, do you have a preference for how it should be implemented?

@rakita
Copy link
Member

rakita commented Oct 20, 2022

Can be done similar to this: #235 (comment)

Just curious, wouldn't increasing block.gas_limit or making tx.gas_limit same as block.gas_limit solve this?

@Wodann
Copy link
Contributor Author

Wodann commented Oct 20, 2022

This is the motivation for having an override: ethereumjs/ethereumjs-monorepo#1014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants