Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and implement formatting for errors #740

Closed
DaniPopes opened this issue Sep 22, 2023 · 1 comment
Closed

Document and implement formatting for errors #740

DaniPopes opened this issue Sep 22, 2023 · 1 comment

Comments

@DaniPopes
Copy link
Collaborator

DaniPopes commented Sep 22, 2023 •
edited
Loading

InvalidTransaction, InvalidHeader etc (crates/primitives/src/result.rs) do not implement std::fmt::Display or std::error::Error, which forces downstream crates to implement their own formatting/conversions (see Foundry, Reth)
@refcell refcell mentioned this issue Oct 5, 2023
Merged
@rakita
Copy link
Member

rakita commented Oct 11, 2023

done

@rakita rakita closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakita @DaniPopes