Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultProps JS Warning #124

Closed
JamesPlayer opened this issue Oct 25, 2017 · 4 comments
Closed

defaultProps JS Warning #124

JamesPlayer opened this issue Oct 25, 2017 · 4 comments
Labels

Comments

@JamesPlayer
Copy link

Getting this warning in Google Chrome console when viewing BlueKit component in the browser:

Warning: Setting defaultProps as an instance property on Select is not supported and will be ignored. Instead, define defaultProps as a static property on Select.

Here's my package.json

{
  "dependencies": {
    "@rails/webpacker": "^3.0.2",
    "babel-preset-react": "^6.24.1",
    "classnames": "^2.2.5",
    "node-persist": "^2.1.0",
    "prop-types": "^15.6.0",
    "react": "^16.0.0",
    "react-bluekit": "^0.4.3",
    "react-dom": "^16.0.0",
    "react-redux": "^5.0.6",
    "react-router-dom": "^4.2.2",
    "redux": "^3.7.2"
  },
  "devDependencies": {
    "eslint": "4.9.0",
    "eslint-config-airbnb": "16.1.0",
    "eslint-plugin-import": "2.8.0",
    "eslint-plugin-jsx-a11y": "6.0.2",
    "eslint-plugin-react": "7.4.0",
    "webpack-dev-server": "^2.9.3"
  },
  "scripts": {
    "bluekit": "bluekit --baseDir ./app/webpack --paths . --exclude \"((?!.*/components/)|.*/components/container/).*\""
  }
}
@kepi74
Copy link
Contributor

kepi74 commented Oct 25, 2017

Thank you for finding inconsistency in React Bluekit code. I prepared PR with fix of this warning.

@kepi74 kepi74 added the bug label Oct 25, 2017
@imtoo
Copy link
Contributor

imtoo commented Oct 25, 2017

Resolved in #126

@imtoo imtoo closed this as completed Oct 25, 2017
@kepi74
Copy link
Contributor

kepi74 commented Oct 25, 2017

@JamesPlayer New version, 0.4.4, is released to npm. Check it out, please.

@JamesPlayer
Copy link
Author

Works perfectly, warnings are gone thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants