fix: image classname on <noscript> img #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve inferred class names on `<noscript>` images that are passed from props. Keeps styling consistent for SSR when users/bots do not have javascript enabled.
bluebill1049
approved these changes
Jul 9, 2019
|
thanks a lot :) 👍 |
|
No problem, thanks for this utility. Saved me a lot of time and effort. More than happy to contribute. Smart move implementing noscript, intersection observers are not widely adopted by indexing engines yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve inferred class names on
<noscript>images that are passed from props.Keeps styling consistent for SSR when users/bots do not have javascript enabled.