set_chaddr: Fix the hardware setting #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current `set_chaddr()` function expects a `[u8;16]` slice due to requirement of `copy_from_slice()`. This cause the `hlen` been always set to 16. This patch fix it by allowing variable length of input u8 slice and set `hlen` accordingly. Tested in my person project with dnsmasq: * Before: `DHCPREQUEST(eth1.ep) 192.0.2.32` `12:a9:63:e8:f0:b8:00:00:00:00:00:00:00:00:00:00` * After: `DHCPREQUEST(eth1.ep) 192.0.2.32 12:a9:63:e8:f0:b8` Signed-off-by: Gris Ge <fge@redhat.com>
|
Thanks for the PR! Sorry for the late response, I didn't get a notification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
set_chaddr()function expects a[u8;16]slice due torequirement of
copy_from_slice(). This cause thehlenbeen alwaysset to 16.
This patch fix it by allowing variable length of input u8 slice and set
hlenaccordingly.Tested in my person project with dnsmasq:
Before:
DHCPREQUEST(eth1.ep) 192.0.2.3212:a9:63:e8:f0:b8:00:00:00:00:00:00:00:00:00:00After:
DHCPREQUEST(eth1.ep) 192.0.2.32 12:a9:63:e8:f0:b8