Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Objectify" bc_record, bc_event_cam etc. #226

Closed
ghost opened this issue Jul 1, 2014 · 0 comments
Closed

"Objectify" bc_record, bc_event_cam etc. #226

ghost opened this issue Jul 1, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 1, 2014

Some important entities in code are implemented as struct and bare C functions with respective prefix in names. This is inevitable inconvenience in pure C projects, but we use C++ compiler and can have use its benefits.
More than that, such structs and their "methods" are often put to different files, and even more, the name of that file doesn't match anything, which makes it a headache to track things.
This prevents the feature developed for #160 to be effective, see https://github.com/bluecherrydvr/bluecherry-apps/blob/xml_status/server/bc-thread.cpp#L485

As i have said in #160, it is better to be done NOT in parallel with any other new features, to avoid merging problems. Also such rework shouldn't be targeting 2.2 stable branch. So it makes sense to implement as "last commit on 2.3" - when there's nothing planned for backporting to 2.2.

@ghost ghost added this to the 2.3 milestone Jul 1, 2014
@ghost ghost added Priority - Medium labels Jul 1, 2014
@ghost ghost self-assigned this Jul 1, 2014
@ghost ghost changed the title "Objectify" bc_record, bc_event_cam "Objectify" bc_record, bc_event_cam etc. Jul 1, 2014
@andrey-utkin andrey-utkin unassigned ghost Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant