-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native builds failing #28
Comments
Hi @paulrutter, it looks like the runner has switched to python3 whereas the code in node-gyp is expecting to use python2. I suspect this could be resolved by upgrading the node-gyp version, like we do in the Windows build. It looks like the Windows build was automatically cancelled though so I can't say for sure. I'll try updating it in my fork and send a PR if it works. |
Ok great, thanks for your quick response! |
@spmiller any update on this one? |
Hi @paulrutter, so sorry for not updating you back in July. I recall writing an update in here but it obviously didn't send. The root of the issue seems to be that Node12 has been removed from Github actions, and some of the tasks are now running on Node16: If I change the config file to only prebuild versions for Node16+, everything is green again. I could submit a patch to do this if you like? It doesn't drop support for the older versions, it just doesn't prebuild them. |
That sounds great @spmiller, please do :) |
Merge branch 'change-to-old-agent' # Conflicts: # .github/workflows/publish-native-assets-to-github-releases.yml
This on is fixed. |
See https://github.com/blueconic/node-oom-heapdump/actions/runs/5643075202
@spmiller any idea whats causing this to fail? Might be that the github action scripts need adjusting, since we didn’t release for a while.
Let me know
The text was updated successfully, but these errors were encountered: