Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native builds failing #28

Closed
paulrutter opened this issue Jul 24, 2023 · 6 comments
Closed

Native builds failing #28

paulrutter opened this issue Jul 24, 2023 · 6 comments

Comments

@paulrutter
Copy link
Contributor

See https://github.com/blueconic/node-oom-heapdump/actions/runs/5643075202

@spmiller any idea whats causing this to fail? Might be that the github action scripts need adjusting, since we didn’t release for a while.

Let me know

@paulrutter paulrutter assigned paulrutter and unassigned paulrutter Jul 24, 2023
@spmiller
Copy link
Contributor

Hi @paulrutter, it looks like the runner has switched to python3 whereas the code in node-gyp is expecting to use python2. I suspect this could be resolved by upgrading the node-gyp version, like we do in the Windows build. It looks like the Windows build was automatically cancelled though so I can't say for sure.

I'll try updating it in my fork and send a PR if it works.

@paulrutter
Copy link
Contributor Author

Ok great, thanks for your quick response!
Let me know if i need to review something.

@paulrutter
Copy link
Contributor Author

@spmiller any update on this one?

@spmiller
Copy link
Contributor

Hi @paulrutter, so sorry for not updating you back in July. I recall writing an update in here but it obviously didn't send.

The root of the issue seems to be that Node12 has been removed from Github actions, and some of the tasks are now running on Node16:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

If I change the config file to only prebuild versions for Node16+, everything is green again.

I could submit a patch to do this if you like? It doesn't drop support for the older versions, it just doesn't prebuild them.

@paulrutter
Copy link
Contributor Author

That sounds great @spmiller, please do :)

paulrutter added a commit that referenced this issue Oct 26, 2023
Merge branch 'change-to-old-agent'

# Conflicts:
#	.github/workflows/publish-native-assets-to-github-releases.yml
@paulrutter
Copy link
Contributor Author

This on is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants