Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which model is really the best? #3

Closed
ducha-aiki opened this issue Jul 28, 2022 · 5 comments
Closed

Which model is really the best? #3

ducha-aiki opened this issue Jul 28, 2022 · 5 comments

Comments

@ducha-aiki
Copy link

Hi,

There are several models available.
Which model is the best? I am on the way of integrating your models into https://github.com/kornia/kornia and would like to make good general purpose defaults.

Also, one more question - am I right that your evaluation on the IMC did not use scale/ori for descriptor calculation, but only for AdaLAM filtering?

@bluedream1121
Copy link
Owner

Hello, Dmytro.

To obtain the best model, you first run these scripts on your terminal:

cd trained_models
bash download_sca_model.sh
bash download_ori_model.sh

The best model for scale estimation is in the following directory:

trained_models/_0621_092607_resnet18_ori36_sca13_branchsca/best_model.pt

The best model for orientation estimation is in the following directory:

trained_models/_0213_121404_resnet18_ori36_sca13_branchori/best_model.pt

Yes, we don't use the scale and orientation for patch normalization (before the descriptor extraction stage) on the IMC dataset evaluation but only use the sca/ori in the AdaLAM filtering stage.

Thank you.

@ducha-aiki
Copy link
Author

Thank you.

One more question - both models (scale and ori) also output other thing - ori and scale. So, what it is best single model? :)

@bluedream1121
Copy link
Owner

Hello. Our proposed method is to train the scale and the orientation separately. We tried to train the joint model of scale/orientation, but the separately trained model performed better.

For that reason, the scale best model and the orientation best model are provided separately.

@ducha-aiki
Copy link
Author

Thank you. And finally - have you checked if the performance degrades on the grayscale images?

@bluedream1121
Copy link
Owner

bluedream1121 commented Jul 29, 2022

No, I did not check the performance degrades on the grayscale images.
Because we trained our model using RGB source image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants