Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReconnectLDAPObject to make connection more robust. #41

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Use ReconnectLDAPObject to make connection more robust. #41

merged 1 commit into from
Aug 7, 2018

Conversation

joka
Copy link
Contributor

@joka joka commented Jul 29, 2018

Use ldap.ldapobject.ReconnectLDAPObject instead of
SimpleLDAPObject to create the connection object.
This makes the connection more robust.

Add properties retry_max (default 1) and retry_delay (default 10)
to node.ext.ldap.properties.LDAPServerProperties to configure
ReconnectLDAPObject.

Use ``ldap.ldapobject.ReconnectLDAPObject`` instead of
``SimpleLDAPObject`` to create the connection object.
  This makes the connection more robust.

Add properties `retry_max` (default 1) and `retry_delay` (default 10)
to ``node.ext.ldap.properties.LDAPServerProperties`` to configure
``ReconnectLDAPObject``.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.514% when pulling e67fb28 on joka:use_reconnect_ldap_object into 29c0931 on bluedynamics:master.

@jensens
Copy link
Member

jensens commented Jul 31, 2018

@joka, LGTM, I just would like to have a review by @rnixx before (will take a while since he is travelling these days).

@jensens jensens requested a review from rnixx July 31, 2018 07:58
@rnixx
Copy link
Member

rnixx commented Aug 7, 2018

@joka Thank you!

@rnixx rnixx merged commit edbc9c5 into conestack:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants