Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip found LDAP objects that miss required attributes #49

Merged

Conversation

mauritsvanrees
Copy link
Contributor

Skip objects that were found in LDAP while searching on several attributes but don't contain the required attribute. We see this on the sharing tab when searching for ('van').

(Somehow when this error occurs, the LDAP (or maybe memcache) does not find any users in future requests, until you restart the Zope instance, but that is a separate issue.)

Original fix by Fred, cherry-picked by Maurits.

This replaces PR #37. Not sure if there is anything left to do for that one.

cc @rnixx

…butes but don't contain the required attribute.

Original fix by Fred, cherry-picked by Maurits.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.546% when pulling dde8485 on zestsoftware:zest-fix-searchlist-attributes into 16e234c on bluedynamics:master.

@rnixx
Copy link
Member

rnixx commented Sep 6, 2019

Thank you!

@rnixx rnixx merged commit fdc39be into conestack:master Sep 6, 2019
@mauritsvanrees mauritsvanrees deleted the zest-fix-searchlist-attributes branch September 7, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants