New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android)!: configurable SoundPool and AudioManager.mode
#1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustl22
changed the title
feat(android)!: configurable soundpool
feat(android)!: configurable SoundPool
Jan 16, 2023
Gustl22
commented
Jan 17, 2023
...dioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/MediaPlayerPlayer.kt
Outdated
Show resolved
Hide resolved
...audioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/SoundPoolPlayer.kt
Outdated
Show resolved
Hide resolved
…ndpool # Conflicts: # packages/audioplayers/example/lib/tabs/audio_context.dart
Gustl22
changed the title
feat(android)!: configurable SoundPool
feat(android)!: configurable SoundPool and Jan 21, 2023
AudioManager.mode
Consider adding the bullets in the PR description, when squashing. |
This was referenced Jan 21, 2023
spydon
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaPlayer
AudioMode
to AudioContextAndroidAudioManager.mode
andAudioManager.isSpeakerphoneOn
onsetGlobalAudioContext
Description
SoundPool could not be configured with AudioContext attributes. This Merge Request adds the functionality to also configure playing sources in LOW_LATENCY mode.
Checklist
fix:
,feat:
,docs:
,chore:
etc).///
, where necessary.Breaking Change
Migration instructions
If you create an AudioPlayer in
LOW_LATENCY
mode, it's presets are not the same as before as they are taken from theAudioContext
now. Nether the less you can set them via:Set context globally, before creating a player:
Set context for an existing single player:
Related Issues
Closes #1240
Closes #135
Related:
#1202
#1321
#934