Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract AudioContext from audio_context_config #1440

Merged
merged 1 commit into from Mar 18, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Mar 18, 2023

Description

To properly extend the audioplayers_platform_interface it is necessary to expose some of their classes. To do this in a further step, it is cleaner to extract the AudioContext from the audio_context_config and only expose the AudioContext and not the AudioContextConfig in the platform interface.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change, but if one directly imports from audioplayers_platform_interface/api instead of audioplayers one will need to change the import statement.

Migration instructions

Before:

import 'package:audioplayers_platform_interface/api/audio_context_config.dart';

After:

import 'package:audioplayers_platform_interface/api/audio_context.dart';
import 'package:audioplayers_platform_interface/api/audio_context_config.dart';

If the PR is breaking, uncomment this header and add instructions for how to migrate from the
currently released version to the new proposed way.

Related Issues

#1352

@Gustl22 Gustl22 requested a review from spydon March 18, 2023 14:48
@Gustl22 Gustl22 enabled auto-merge (squash) March 18, 2023 15:08
@Gustl22 Gustl22 merged commit e59c3b9 into main Mar 18, 2023
7 checks passed
@Gustl22 Gustl22 deleted the gustl22/split-audio_context branch March 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants