Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt position update interval of darwin, linux, web #1492

Merged
merged 2 commits into from May 7, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented May 7, 2023

Description

  • Linux: changed update interval from 1000ms to 250ms
  • Web: position was rounded to 1s as its handed over as float, now it's multiplied with 1000 to profit from millisecond precision, update interval is still dependent on browser implementation
  • Darwin: changed update interval from 0.2ms to 200ms, which most probably was a mistake and caused much overhead

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 requested a review from spydon May 7, 2023 11:17
@Gustl22 Gustl22 merged commit ab5bdf6 into main May 7, 2023
7 checks passed
@Gustl22 Gustl22 deleted the gustl22/position-precision branch May 7, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants