fix: Timeout on setting same source twice #1520

Gustl22 · 2023-05-25T17:02:13Z

Description

When setting the same source twice for a player, the onPrepared event was not sent on most implementations.

The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
I have read the Contributor Guide and followed the process outlined for submitting PRs.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
I have updated/added relevant examples in example.

This reverts commit fc42ef8.

Gustl22 added 3 commits May 25, 2023 18:47

feat(windows): set same source twice

b1517d6

fix: set same source twice

dbfc405

revert unrelated changes from other branch

c341ab0

Gustl22 marked this pull request as ready for review May 25, 2023 17:05

Gustl22 added 5 commits May 25, 2023 20:15

avoid cancelling sub

5325394

readd cancel the sub

7fb0d9f

fix: avoid cancelling last listener

fc42ef8

Revert "fix: avoid cancelling last listener"

da64070

This reverts commit fc42ef8.

fix: listen and cancel same channel twice

1e9774e

Gustl22 requested review from luanpotter and spydon May 28, 2023 12:08

spydon approved these changes May 28, 2023

View reviewed changes

Gustl22 merged commit 5d164d1 into main May 28, 2023
7 checks passed

Gustl22 deleted the gustl22/fix-same-source branch May 28, 2023 21:53