Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): allow reusing event channel with same name #1555

Merged
merged 37 commits into from Jul 19, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Jun 28, 2023

Description

Fixes #1498

Can go back to stable flutter, when flutter/flutter@c7f82a1 is released.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1498

@Gustl22 Gustl22 requested a review from spydon June 28, 2023 15:47
@Gustl22 Gustl22 marked this pull request as draft July 5, 2023 11:33
@Gustl22 Gustl22 force-pushed the gustl22/1498-reuse-channel branch from 35b9095 to bc1ff65 Compare July 18, 2023 18:39
add one pump again

remove one pump

more pumps

[WIP]: disable linux tests

debug 4

Revert "Revert "some debug 3""

This reverts commit bc1ff65.

Revert "some debug 3"

This reverts commit dcc4eac.

some debug 3

some debug 2

some debug

readd tests

[WIP]: use flutter master again

lib test open and close channel

[WIP]: use stable again
This reverts commit 5ef4159.
This reverts commit 49b6bdd.
@Gustl22 Gustl22 force-pushed the gustl22/1498-reuse-channel branch from 77a4f3a to 00d97d5 Compare July 18, 2023 20:27
@Gustl22 Gustl22 marked this pull request as ready for review July 18, 2023 20:27
@Gustl22 Gustl22 enabled auto-merge (squash) July 19, 2023 09:47
@Gustl22 Gustl22 marked this pull request as draft July 19, 2023 13:06
auto-merge was automatically disabled July 19, 2023 13:06

Pull request was converted to draft

@Gustl22 Gustl22 marked this pull request as ready for review July 19, 2023 13:56
@Gustl22 Gustl22 merged commit 5471189 into main Jul 19, 2023
7 checks passed
@Gustl22 Gustl22 deleted the gustl22/1498-reuse-channel branch July 19, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track: Can't reuse event channel with same name on Linux
2 participants