Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Lint Kotlin, C and C++ code #1610

Merged
merged 28 commits into from Aug 20, 2023
Merged

refactor: Lint Kotlin, C and C++ code #1610

merged 28 commits into from Aug 20, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Aug 17, 2023

Description

Test Linting Github Action Super Linter, to uniform source code:
https://github.com/marketplace/actions/super-linter

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1587

@Gustl22 Gustl22 marked this pull request as draft August 17, 2023 20:34
@Gustl22 Gustl22 changed the title ci: Lint all code ci: Lint Kotlin, C and C++ code Aug 19, 2023
@Gustl22 Gustl22 changed the title ci: Lint Kotlin, C and C++ code refactor: Lint Kotlin, C and C++ code Aug 19, 2023
@Gustl22 Gustl22 marked this pull request as ready for review August 19, 2023 23:35
@Gustl22 Gustl22 requested a review from spydon August 20, 2023 02:16
@spydon spydon requested a review from luanpotter August 20, 2023 03:08
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES YES YES!
I love this.

@luanpotter
Copy link
Member

we need to add this to gamepads as well

@luanpotter luanpotter merged commit 0539466 into main Aug 20, 2023
16 checks passed
@luanpotter luanpotter deleted the gustl22/linting branch August 20, 2023 03:24
@luanpotter
Copy link
Member

we should consider adding instructions to our CONTRIBUTING files on how to run these linters separately locally though

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Aug 20, 2023

I'll try to also implement it for Swift, and add the linting setup then.

@Gustl22 Gustl22 mentioned this pull request Aug 21, 2023
7 tasks
Gustl22 added a commit that referenced this pull request Sep 26, 2023
Test Linting Github Action Super Linter, to uniform source code:
https://github.com/marketplace/actions/super-linter

(cherry picked from commit 0539466)
Gustl22 added a commit that referenced this pull request Nov 14, 2023
Test Linting Github Action Super Linter, to uniform source code:
https://github.com/marketplace/actions/super-linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants