Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set playback rate only when playing #1658

Merged
merged 6 commits into from Oct 1, 2023
Merged

fix: Set playback rate only when playing #1658

merged 6 commits into from Oct 1, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Oct 1, 2023

Description

Fixes #468

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Related Issues

@Gustl22 Gustl22 changed the title fix(darwin): Set player.rate only when playing fix: Set playback rate only when playing Oct 1, 2023
@Gustl22 Gustl22 requested a review from spydon October 1, 2023 13:23
@Gustl22 Gustl22 merged commit d73c7d5 into main Oct 1, 2023
8 checks passed
@Gustl22 Gustl22 deleted the 468-darwin-fix-rate branch October 1, 2023 13:48
Gustl22 added a commit that referenced this pull request Oct 1, 2023
Gustl22 added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setPlaybackRate misfunction
2 participants