feat!: FramePositionUpdater & TimerPositionUpdater #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustl22
changed the title
Gustl22
commented
Oct 17, 2023
| void _tick(Duration? timestamp) { | ||
| if (_isRunning) { | ||
| update(); | ||
| _frameCallbackId = SchedulerBinding.instance.scheduleFrameCallback(_tick); |
There was a problem hiding this comment.
@spydon as you're also working on flame, which also uses frame based updates (I think). Do you think this is a valid approach for providing a smooth experience to display position updates? Or should this be made optional and use a the TimerPositionUpdater as first option?
There was a problem hiding this comment.
This approach should be good I think!
spydon
approved these changes
Oct 17, 2023
spydon
reviewed
Oct 17, 2023
...audioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/SoundPoolPlayer.kt
Outdated
Show resolved
Hide resolved
Gustl22
changed the title
Gustl22
force-pushed
the
gustl22/349-configurable-position-updates
branch
from
0d7102f
to
61a2b50
Compare
…rable-position-updates # Conflicts: # packages/audioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/SoundPoolPlayer.kt
Gustl22
commented
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PositionUpdater:FramePositionUpdater.AudioPlayer.positionUpdatertoTimerPositionUpdater, the position stream is updated in the according interval.SoundPoolPlayer.Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
If the PR is a breaking change this should be indicated with suffix "!"
(for example,
feat!:,fix!:). See Conventional Commit for details. -->Migration instructions
Removed in
audioplayers_platform_interface:Related Issues
Closes #349
Closes #1525