Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move device properties to side panel instead of pop-up #96

Closed
lohnn opened this issue Nov 18, 2022 · 9 comments
Closed

Move device properties to side panel instead of pop-up #96

lohnn opened this issue Nov 18, 2022 · 9 comments

Comments

@lohnn
Copy link
Contributor

lohnn commented Nov 18, 2022

Adding interactive side panel device info settings would make it possible for users to quickly try out different device settings.

My idea is something akin to this:
image

If you agree that this is a good idea, you can assign me as I'm taking a stab at this 👍

@erickzanardo
Copy link
Member

Hey 🖖

I am not sure I fully understand, is there any more differences other than just changing the modal to a side panel?

@lohnn
Copy link
Contributor Author

lohnn commented Nov 19, 2022

Well, some small GUI tweaks to tailor it to side panel of course. I'd propose moving the device orientation and "show device frame" buttons to the side panel to keep them with the device settings.
But mainly making it updating the device settings in real time as you update the values in the side panel. Like sliding the text scale factor updates the text in real time in the preview. Like such:

Screen.Recording.2022-11-19.at.16.11.43.mov

@erickzanardo
Copy link
Member

I like the idea, the only addition that I would suggest is to add a checkbox with the label use custom device, that would be unchecked by default.

Once it is checked, then the custom device fields would appear, wdyt?

@lohnn
Copy link
Contributor Author

lohnn commented Nov 28, 2022

Love it! Just the piece of UX puzzle I was looking for to make it more understandable. I'll continue on the code for this and make it a PR in a few days when I have time again, a bit choked as of now.

@lohnn
Copy link
Contributor Author

lohnn commented Dec 9, 2022

Finally had some time to spare. How would this be as a first version?

Screen.Recording.2022-12-09.at.13.48.16.mov

@erickzanardo
Copy link
Member

That LGTM! Awesome

@lohnn
Copy link
Contributor Author

lohnn commented Dec 9, 2022

Then I'll make sure the tests are running properly and make a PR :)

@lohnn
Copy link
Contributor Author

lohnn commented Dec 9, 2022

Then there is a PR to look at ;) #98

@erickzanardo
Copy link
Member

Solved by #98 released on 0.1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants