-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move device properties to side panel instead of pop-up #96
Comments
Hey 🖖 I am not sure I fully understand, is there any more differences other than just changing the modal to a side panel? |
Well, some small GUI tweaks to tailor it to side panel of course. I'd propose moving the device orientation and "show device frame" buttons to the side panel to keep them with the device settings. Screen.Recording.2022-11-19.at.16.11.43.mov |
I like the idea, the only addition that I would suggest is to add a checkbox with the label use custom device, that would be unchecked by default. Once it is checked, then the custom device fields would appear, wdyt? |
Love it! Just the piece of UX puzzle I was looking for to make it more understandable. I'll continue on the code for this and make it a PR in a few days when I have time again, a bit choked as of now. |
Finally had some time to spare. How would this be as a first version? Screen.Recording.2022-12-09.at.13.48.16.mov |
That LGTM! Awesome |
Then I'll make sure the tests are running properly and make a PR :) |
Then there is a PR to look at ;) #98 |
Solved by #98 released on |
Adding interactive side panel device info settings would make it possible for users to quickly try out different device settings.
My idea is something akin to this:
![image](https://user-images.githubusercontent.com/960157/202815942-0b26d1ba-0652-49d2-b1bf-caa0326d0dcb.png)
If you agree that this is a good idea, you can assign me as I'm taking a stab at this 👍
The text was updated successfully, but these errors were encountered: