Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract class for easy maintenance #2

Closed
genericFJS opened this issue Jan 16, 2019 · 1 comment
Closed

Abstract class for easy maintenance #2

genericFJS opened this issue Jan 16, 2019 · 1 comment
Assignees
@alxnull

Comments

@genericFJS
Copy link
Contributor

Right now there are two classes (one for each project) which have mostly the same code.
Maybe implement an abstract class and let the two specialized classes inherit to make changes easier.
In commit/pull request #1 I had to add/edit 6 lines instead of 3.
@alxnull
Copy link
Member

alxnull commented Jan 20, 2019

You're absolutely right with your suggestion, currently, many parts of the two classes are redundant which clearly isn't the best style. I'll do some refactoring and introduce a common base class for both implementations to improve this.

@alxnull alxnull self-assigned this Jan 20, 2019
@alxnull alxnull closed this as completed in eba8df6 Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxnull alxnull

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genericFJS @alxnull