Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Signup Interaction #134

Open
tzfx opened this issue Jun 5, 2020 · 1 comment
Open

Better Signup Interaction #134

tzfx opened this issue Jun 5, 2020 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@tzfx
Copy link
Contributor

tzfx commented Jun 5, 2020

Currently, if a user submits a request to sign-up, they are logged into the application on form completion.

This login puts them in a state where they are logged in without user roles or approval, and are immediately thrown to an 'unauthorized' page and it will stay that way util they are approved and they do a refresh of the page. Two options stick out as ways to improve this interaction:

  1. Do not log the user in automatically on completion of the sign-in.
  2. Log them in, but make it clear that their account is awaiting approval (if the app is configured to require approval).

I am leaning toward just not logging them in at all on Signup request. If they complete signup and there is no approval step, have them manually sign in.

@tzfx tzfx added enhancement New feature or request question Further information is requested labels Jun 5, 2020
@tzfx
Copy link
Contributor Author

tzfx commented Jun 5, 2020

Additionally, it seems like we shouldn't actually allow them to log-in if their account is not yet activated. Currently, it looks like you can login without an active account and get stuck in this same state manually. As part of this ticket, we should revise the application to more clearly indicate that the account has not yet been activated and refuse to login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant