Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Targetting native fonts #208

Open
tzfx opened this issue May 27, 2021 · 0 comments
Open

Discussion: Targetting native fonts #208

tzfx opened this issue May 27, 2021 · 0 comments
Labels
dependencies Pull requests that update a dependency file question Further information is requested

Comments

@tzfx
Copy link
Contributor

tzfx commented May 27, 2021

Hello there!

The default font set in typography.css appears to be 'roboto'-- this is also brought in via NPM dependency and delivered to clients.

I think we should change this so the default attempts to load native fonts- Github uses the following base font-family definition:

font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

And here is a post covering the why and how behind their change: https://markdotto.com/2018/02/07/github-system-fonts/ along with some information on how they iterated through a few options for this.

Additionally, it appears that we definite bold/italic/light font families in typography. I think we should identify where these are being used and instead utilize <strong> or <em> tags instead. This also should allow us to remove the roboto font dependency that we are currently bringing in via NPM.

@tzfx tzfx added dependencies Pull requests that update a dependency file question Further information is requested labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant