Enable more digest-related functionality for *ring*. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
reviewed
Sep 22, 2017
client/src/rr/dnssec/digest_type.rs
Outdated
| /// This will always error, enable openssl feature at compile time | ||
| #[cfg(not(feature = "openssl"))] | ||
| #[cfg(not(any(feature = "openssl", feature = "ring")))] | ||
| pub fn hash(&self, _: &[u8]) -> DnsSecResult<Vec<u8>> { | ||
| Err(DnsSecErrorKind::Message("openssl feature not enabled").into()) |
There was a problem hiding this comment.
maybe change this error to say "openssl or ring"?
client/src/rr/dnssec/digest_type.rs
Outdated
| pub fn digest_all(&self, data: &[&[u8]]) -> DnsSecResult<Digest> { | ||
| use std::io::Write; | ||
|
|
||
| let digest_type = try!(self.to_openssl_digest()); |
There was a problem hiding this comment.
just an FYI, I'm slowly upgrading the code to use ? instead of try!. This doesn't need to be changed, but if you want to use '?' feel free.
There was a problem hiding this comment.
Let's leave it using try! for this set of patches, but I'll remember this in the future and switch to ?.
| } else { | ||
| return false; | ||
| }) | ||
| .map(|hash| hash.as_ref() == self.digest()) |
There was a problem hiding this comment.
ha, I love it when I forget to just return the result of ==. This is definitely cleaner.
|
This looks ready to go, as it passed CI and I addressed your review comments. |
|
Just needed to update the branch. Assuming tests pass, I'll merge in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.