Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on unused external crates from client/. #256

Merged
merged 5 commits into from Oct 25, 2017
Merged

Remove dependencies on unused external crates from client/. #256

merged 5 commits into from Oct 25, 2017

Conversation

briansmith
Copy link
Contributor

No description provided.

@bluejekyll
Copy link
Member

Is there a test we can add for this, to make sure that there are no unused dependencies?

@briansmith
Copy link
Contributor Author

Is there a test we can add for this, to make sure that there are no unused dependencies?

rustc (at least, rustc 1.23 Nightly) will issue a warning when building a crate that has an extern create $X where $X isn't used anywhere. That's how I noticed some of these.

I know of no way to automatically find out that Cargo.toml references crates that aren't used. I am manually going through the Cargo.tomls and removing the dependencies by hand.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.397% when pulling 46aa3e6 on briansmith:client-minimize-deps into 227c77a on bluejekyll:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.378% when pulling 46aa3e6 on briansmith:client-minimize-deps into 227c77a on bluejekyll:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.397% when pulling 60eef84 on briansmith:client-minimize-deps into 0bb0b2c on bluejekyll:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.378% when pulling 31ebc0b on briansmith:client-minimize-deps into 9da5578 on bluejekyll:master.

@bluejekyll bluejekyll merged commit dcb4971 into hickory-dns:master Oct 25, 2017
@briansmith briansmith deleted the client-minimize-deps branch October 30, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants