Don't enable DNSSEC by default in -resolver. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I worry about the ipconfig part. On Win64 this is necessary for nameserver configuration based on the system. Won't this make configuration of DNS more difficult in that environment? I agree about getting rid of the default dependency on OpenSSL and DNSSec. |
I will pull the ipconfig part out of the PR. |
It is too easy for a library to accidentally add an OpenSSL dependency through Trust-DNS by using Trust-DNS without disabling the default features. This is especially bad because a library that hasn't consciously chosen what to do about DNSSEC won't provide any APIs for controlling if DNSSEC is used or how to configure its use (e.g. configuring trust anchors). Resolve both by defaulting to not having DNSSEC by default.
briansmith
changed the title
bluejekyll
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is too easy for a library to accidentally add an OpenSSL dependency
through Trust-DNS by using Trust-DNS without disabling the default
features. This is especially bad because a library that hasn't
consciously chosen what to do about DNSSEC won't provide any APIs for
controlling if DNSSEC is used or how to configure its use (e.g.
configuring trust anchors).
The same applies to the ipconfig configure.
Resolve both by defaulting to not having these features.