Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ClientHandle api return Send #465

Merged
merged 2 commits into from
May 15, 2018
Merged

Conversation

ariwaranosai
Copy link
Contributor

api of clientHandle should return Send, since lookup and send all return Send.

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I must have missed this in my changes.

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #465 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   86.59%   86.51%   -0.09%     
==========================================
  Files         133      133              
  Lines       13428    13428              
==========================================
- Hits        11628    11617      -11     
- Misses       1800     1811      +11
Impacted Files Coverage Δ
client/src/client/client_future.rs 98.91% <100%> (ø) ⬆️
resolver/src/name_server_pool.rs 84.43% <0%> (-1.89%) ⬇️
proto/src/udp/udp_stream.rs 91.33% <0%> (-1.58%) ⬇️
proto/src/xfer/dns_future.rs 79.7% <0%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7e343...969e8cb. Read the comment docs.

@bluejekyll
Copy link
Member

Thanks again for this patch!

@bluejekyll bluejekyll merged commit 2f22e5a into hickory-dns:master May 15, 2018
@ariwaranosai
Copy link
Contributor Author

You’re welcome. I'm looking forward to release with tokio.

@bluejekyll
Copy link
Member

I've started working on putting that together... I need to go back and review the CHANGELOG entries. I'm hoping to have time to do this over the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants