Support MX record pointing to root label, meaning no service available. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluejekyll
changed the title
. as MX target
|
@Darkspirit this should fix the issue you discovered. |
stop additional lookup on Root name
bluejekyll
force-pushed
the
add-support-for-no-service
branch
from
0ce9b08
to
3850b64
Compare
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 85.87% 85.88% +<.01%
==========================================
Files 122 122
Lines 13288 13289 +1
==========================================
+ Hits 11411 11412 +1
Misses 1877 1877 |
|
Yes, it seems to be fixed. Thank you! :) |
|
Ok, cool, thanks for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #980