Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor - Feature activation -> also use in header files #39

Open
benjaminaigner opened this issue May 29, 2017 · 2 comments
Open

Comments

@benjaminaigner
Copy link

If BTStack is configured to omit one feature (e.g.: ENABLE_LE_DATA_CHANNELS), there are still all prototypes available in the headers --> other source files compile nice, BUT: undefined reference during linking.

Suggestion:
Disable function headers in header files too, might be easier to find disabled stack parts.

@mringwal
Copy link
Member

good point. I was wondering about what to do with the prototypes. Adding #ifdefs makes them uglier, but compile errors are easier to understand than link errors in my opinion. I guess I'll follow your suggestion here.

@benjaminaigner
Copy link
Author

Yes, #ifdefs are not beautiful in header files, but it's much more easy with them :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants