Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better incoming folder fallback selection #2297

Open
1 task done
drws opened this issue Mar 16, 2024 · 6 comments
Open
1 task done

Better incoming folder fallback selection #2297

drws opened this issue Mar 16, 2024 · 6 comments

Comments

@drws
Copy link

drws commented Mar 16, 2024

blueman: v2.3.5
BlueZ: 5.73
Distribution: Arch
Desktop environment: Xfce

If the configured incoming transfer folder is not available, Blueman falls back to home folder, notifying user:

Configured directory for incoming files does not exist
Please make sure that directory /home/user/Incoming exists or configure it with blueman-services. Until then the default /home/user will be used

$HOME is not the best first fallback choice. Much more appropriate would be $XDG_DOWNLOAD_DIR or $XDG_PUBLICSHARE_DIR. Only if the system doesn't have XDG configured then Blueman could fallback to the home folder.

@drws drws changed the title Better fallback incoming folder selection Better incoming folder fallback selection Mar 16, 2024
@infirit
Copy link
Contributor

infirit commented Mar 16, 2024

I disagree

@drws
Copy link
Author

drws commented Mar 18, 2024

Ok. Is there any other option sensible to you than the root of the home directory structure?

@cschramm
Copy link
Member

$XDG_PUBLICSHARE_DIR definitely does not seem like a good idea. Also, as far as I know those variables are not specified in any way. They just come from the xdg-user-dirs tools. The only suitable variable from the XDG Base Directory Specification would be $XDG_DATA_HOME. It defaults to $HOME/.local/share, meaning that it's "hidden", thus doesn't seem appropriate for incoming files either.

$XDG_DOWNLOAD_DIR might be reasonable, if set. 🤷 @infirit, what are your points against it?

@infirit
Copy link
Contributor

infirit commented Mar 18, 2024

Zero reason was given why $HOME is not the best fallback. How is using the XDG_DOWNLOAD_DIR any better or worse?

@drws
Copy link
Author

drws commented Mar 20, 2024

So as not to litter the root of an important directory structure where user expects full control of their non-hidden files. Poorly-ported commercial software does that, FOSS mostly tries to avoid it. And even then files are usually put in a custom subfolder. So tidiness and software hygiene is one.

Also a very great majority of userspace applications categorize their files by default in subfolders so users actually expect files in an appropriate standard subfolder. $XDG_DOWNLOAD_DIR seems like the best choice.

Furthermore, security. To try to limit any potential attacks. There are some important config files and scripts in root of home. It doesn't seem the best folder to push 3rd party data files to. Also a bug could cause data flood or corruption. In all these cases there's simply less damage and damage control is easier if files are categorized/contained at least in one of the general data subfolders.

Even further, convenience. A sensible falback=default selection means there's one less path to worry about when setting up a system.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants