Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinger.Ping() always returns true #11

Open
Peterkn2001 opened this issue Jul 23, 2020 · 0 comments
Open

pinger.Ping() always returns true #11

Peterkn2001 opened this issue Jul 23, 2020 · 0 comments

Comments

@Peterkn2001
Copy link

In the example sketch, the "Error during ping command." message is never seen, as pinger.Ping() always == true, even if the website/IP address is unreachable.

// Ping technologytourist.com
  Serial.printf("\n\nPinging technologytourist.com\n");
  if(pinger.Ping("technologytourist.com") == false)
  {
    Serial.println("Error during ping command.");
  }

A similar issue was raised here: #2
which applied to version 1.0.0 and was supposedly fixed in version 1.1.0
In the 1.x versions the return value was meant to be 0 or -1 rather than true or false.
I tested version 1.1.0 and I couldn't get that to work correctly either.

I suspect that changes to the ESP core may be responsible for these issue, but I've not tested that theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant